refactor: CSS "condition" to SCSS condition #4690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/refactor-css-condition-to-scss-condition |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
changed the title
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This refactoring moves CSS element type checking from runtime CSS :is() selectors to build-time SCSS conditions, improving maintainability and performance by reducing CSS complexity. The change replaces CSS pseudo-selectors with SCSS conditional compilation.
- Replaced CSS
:is(input, textarea)selectors with SCSS@ifconditions usinglist.index() - Added SCSS variables to define valid form field types for read-only and field-sizing properties
- Updated CSS variable naming to be dynamic based on the element type
michaelmkraus
approved these changes
Aug 12, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently we've checked for the elements to be either
inputortextareaat the CSS level with:is(). Instead as we're using those in a SCSS mixin, we should that for check for those element types in a SCSS condition.The main purpose of this is to prevent resulting selectors like
.db-input input:is(input,textarea):not(:disabled):read-only, which becomes.db-input input:not(:disabled):read-onlyTypes of changes
Further comments